Page MenuHomePhabricator

Public | JavaScript download links don't work for some people
Open, Unbreak Now!Public

Description

Diana from South Africa was unable to start a download of Replicator from Firefox and Chrome on Windows 7.

I think this is probably the weird JavaScript I use to start the downloads to avoid cross-linking.

Instead, changing to direct links.

Event Timeline

Joe created this task.Nov 17 2018, 8:06 AM
Joe created this object in space S5 Public.
Joe triaged this task as Unbreak Now! priority.
Joe created this object with visibility "Public (No Login Required)".
Joe added a comment.Nov 17 2018, 8:59 AM

This being the third time I've changed the way downloads work, I've decided to be smart enough to collect the download information into a class so the HTML can be rendered from it. These will be collected into an array of the Power Tool's own descriptor class.

<?php
namespace KarenWare\Tools;

/*
<tr>
<td><a class="download-link" href="#Karens-Directory-Printer-v5.4.2-Setup.exe"
		onclick="return dfile(this,'Karens-Directory-Printer-v5.4.2-Setup.exe');">Karens-Directory-Printer-v5.4.2-Setup.exe</a> <span class="badge badge-success">New!</span><br>
		Download and run to install Directory Printer v5.4.2
		</td>
		<td>5.4.2</td>
		<td>November 15, 2018</td>
		<td class="numcol">1,321,232 bytes</td>
		<td class="numcol" style="font-size: 90%">SHA-1<br>E55ACA499D3B97DE673C18D123E2E888617F83D9<br>
		SHA-256<br>F804CE1A52B93D4AE9EC59DA51A5F49872C873CC030694CA3E5D197235AE3B3E<br>
		<a href="https://www.virustotal.com/#/file/f804ce1a52b93d4ae9ec59da51a5f49872c873cc030694ca3e5d197235ae3b3e" class="external-link font-bold">VirusTotal Scan Results</a>
</td>
</tr>*/

class Download {
	public $filename;
	public $version;
	public $released;
	public $bytes;
	public $sha1;
	public $sha256;
	public $virustotal;
	
	public function __construct( string $filename, string $version, string $released, string $bytes, 
			string $sha1, string $sha265 = null, $virustotal = null ) {
		
	}
}
Joe added a comment.Jan 4 2019, 5:30 PM

The methodology and functions have all been worked out and just needs to be installed on all the pages.